| Karim Belabas on Sun, 20 Jun 2004 17:19:04 +0200 |
[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]
| Re: diviuexact |
* Bill Allombert [2004-06-20 15:55]:
> On Sun, Jun 20, 2004 at 12:25:21PM +0200, Bill Allombert wrote:
> > Karim has started to use diviuexact in elliptic.c, but unfortunately
> > I forgot to implement it in the GMP kernel, so PARI did not build
> > anymore with the GMP kernel.
>
> To prevent similar problems, I made a diff of symbol from both kernel.
> Here is the discrepancy:
>
> Only in none/mp.c:
> addiispec, subiispec, gcd_plus_minus
>
> Only in gmp/mp.c:
> divrr_with_gmp
>
> I suppose we should make gcd_plus_minus and divrr_with_gmp static,
> but what for addiispec and subiispec? (muliispec is public, and
> use in Flx.c).
>
> Note that public and documented is not the same thing.
Just make everything static for the time being. Next time someone (e.g I)
needs them:
1) she'll think twice before using an undocumented routine
2) she'll remove the 'static' keyword but then feel obliged to document the
routine.
Karim.
--
Karim Belabas Tel: (+33) (0)1 69 15 57 48
Dep. de Mathematiques, Bat. 425 Fax: (+33) (0)1 69 15 60 19
Universite Paris-Sud http://www.math.u-psud.fr/~belabas/
F-91405 Orsay (France) http://pari.math.u-bordeaux.fr/ [PARI/GP]