Bill Allombert on Mon, 12 Sep 2005 10:47:15 +0200


[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: bug in qfminim() with pari 2.2.11 (current cvs)


On Sun, Sep 11, 2005 at 10:57:15PM +0200, Philippe Elbaz-Vincent wrote:
> Hi,
> 
> gp > M=[4032, -378, 2268, 756, 3150, 756, 504; -378, 8736, 5796, 756, 
> -378, 756, -966; 2268, 5796, 7560, 756, 2268, 756, 504; 756, 756, 756, 
> 1512, 756, 756, 756; 3150, -378, 2268, 756, 4032, 756, 1386; 756, 756, 756, 
> 756, 756, 1512, 756; 504, -966, 504, 756, 1386, 756, 1680]
> 
> gp > qfminim(M,2*1512,0)
>   *** qfminim: negative number of vectors in minim0.

The attached patch should fix that, but the doc is unclear whether 0
should be allowed or not, though I do not see any rationale for not
allowing it.

Cheers,
Bill.

--- src/basemath/bibli1.c       8 Sep 2005 15:52:23 -0000       1.273
+++ src/basemath/bibli1.c       12 Sep 2005 08:38:00 -0000
@@ -3045,7 +3045,7 @@
   {
     case min_ALL:
       maxrank = itos(STOCKMAX);
-      if (maxrank < 1) err(talker,"negative number of vectors in minim0");
+      if (maxrank < 0) err(talker,"negative number of vectors in minim0");
       L = new_chunk(1+maxrank);
       break;
     case min_PERF: