Bill Allombert on Sat, 14 Jan 2017 16:26:11 +0100


[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Minor improvents to handling of --graphic option


On Mon, Jan 09, 2017 at 04:51:35PM +0100, Jeroen Demeyer wrote:

> >From 9a9e25cdea1851b101a88ac62a06d2c087cbf7a3 Mon Sep 17 00:00:00 2001
> From: Jeroen Demeyer <jdemeyer@cage.ugent.be>
> Date: Mon, 9 Jan 2017 16:06:02 +0100
> Subject: [PATCH 2/2] Simplify handling of --graphic option and check validity

Thanks, I applied the first part.

> diff --git a/config/get_config_options b/config/get_config_options
> index b8c29f9..e64cb6d 100644
> --- a/config/get_config_options
> +++ b/config/get_config_options
> @@ -130,7 +130,7 @@ Options: some names can be abbreviated to one character (e.g -h = -help)
>  Build Options:
>    --host=<arch-osname>  target achitecture
>    --kernel=<kern>       kernel used
> -  --graphic=<gr>        graphic library used (none, X11, Qt, fltk, ps, win32)
> +  --graphic=<gr>        graphic library used (none, X11, Qt, Qt4, fltk, ps, win32)
>    --time=<fun>          timing function to use (getrusage, clock_gettime,
>                            times, ftime)
>    --builddir=<dir>      directory where the object files will be created

This part is not correct, only --graphic=Qt is supported (which will
detect either Qt2, Qt3 or Qt4).

Cheers,
Bill.