Re: factorff() bug

[Karim BELABAS <Karim.Belabas@math.u-psud.fr>]

[Igor:]
> ? factorff(x^7-3,3,y^3+2)
>   ***   bus error: bug in GP (please report).

Typo: two factors were equal, one was cancelled; so nbf (number of distinct
factors) < nbfact (number of factors), and I used the wrong one...

Karim.

*** src/basemath/polarit1.c.orig        Fri Mar  5 08:51:56 1999
--- src/basemath/polarit1.c     Thu Mar 11 17:39:00 1999
***************
*** 1850,1856 ****
      }
    y = gerepile(av,tetpil,y);
    u=(GEN)y[1]; a = forcecopy(tokill);
!   for (j=1; j<nbfact; j++) fqunclone((GEN)u[j], a);
    (void)sort_factor(y, cmp_pol);
    gunclone(tokill); return y;
  }
--- 1850,1856 ----
      }
    y = gerepile(av,tetpil,y);
    u=(GEN)y[1]; a = forcecopy(tokill);
!   for (j=1; j<nbf; j++) fqunclone((GEN)u[j], a);
    (void)sort_factor(y, cmp_pol);
    gunclone(tokill); return y;
  }

--
Karim Belabas                    email: Karim.Belabas@math.u-psud.fr
Dep. de Mathematiques, Bat. 425
Universite Paris-Sud             Tel: (00 33) 1 69 15 57 48
F-91405 Orsay (France)           Fax: (00 33) 1 69 15 60 19
--
PARI/GP Home Page: http://hasse.mathematik.tu-muenchen.de/ntsw/pari/